Fix typo in Rsync.fs options #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 5.18.0
* BUGFIX: Paket module was broken - fsprojects#2413 * BUGFIX: New `CreateProcess.withToolType` wasn't working for `ToolType.FrameworkDependentDeployment` - fsprojects#2412 * ENHANCEMENT: Add support for local dotnet tool to fake-template and make it the default.
* NEW: Add `Fake.DotNet.Testing.Coverlet`, thanks @Tarmil - fsprojects#2413 * BUGFIX: `paket pack` module was broken, thanks @sergey-tihon - fsprojects#2418
* BUGFIX: `Fake.DotNet.Testing.Coverlet` was not working, thanks @Tarmil - fsprojects#2424
|
I'm always a bit worried when you can change code like this without the need to change any tests... |
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's an obvious typo in the command-line options passed to rsync by Rsync.fs:
--zsync-pathshould have been--rsync-path. See the rsync man page for proof that--rsync-pathis the correct spelling.